fix: update image source URL when source size changes#482
Merged
Conversation
1. Added call to updateImageSourceUrl() when setSourceSize() is called 2. Ensures the image URL is properly updated when the source size changes 3. Fixes potential issue where image wouldn't refresh after size change 4. Maintains consistency between source size and displayed image fix: 在源尺寸变化时更新图像源URL 1. 在setSourceSize()被调用时添加了updateImageSourceUrl()的调用 2. 确保当源尺寸变化时图像URL能正确更新 3. 修复了尺寸变化后图像可能不会刷新的问题 4. 保持源尺寸和显示图像之间的一致性 pms: BUG-315703
Contributor
deepin pr auto review关键摘要:
是否建议立即修改:
|
deepin-ci-robot
added a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
May 13, 2025
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#482
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @18202781743 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Reviewer's GuideThis PR ensures that the image source URL is refreshed whenever the source size changes by adding a call to updateImageSourceUrl() within setSourceSize, preventing stale or unrefreshed images. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
mhduiy
approved these changes
May 13, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
18202781743
pushed a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
May 13, 2025
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#482
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes
fix: 在源尺寸变化时更新图像源URL
pms: BUG-315703
Summary by Sourcery
Bug Fixes: